Split "on_success_quorum" into smaller and more manageable functions#2636
Open
autholykos wants to merge 11 commits intomasterfrom
Open
Split "on_success_quorum" into smaller and more manageable functions#2636autholykos wants to merge 11 commits intomasterfrom
autholykos wants to merge 11 commits intomasterfrom
Conversation
Member
autholykos
commented
Oct 9, 2024
autholykos
commented
- simplified flattening of Option
- improved comments
- Refactor on_quorum_msg to handle Success Quorum messages only - Send all quorum messages to the consensus task
fed-franz
force-pushed
the
handle_fail_quorums
branch
from
9e015dc to
6d17634
Compare
autholykos
force-pushed
the
refactor_on_success_quorum
branch
from
3adc9da to
7f90d32
Compare
fed-franz
force-pushed
the
handle_fail_quorums
branch
4 times, most recently
from
d81e4a8 to
deea7b4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.